Checkstyle Results

The following document contains the results of Checkstyle 10.21.3 with /config/dsol-checks.xml ruleset.

Summary

Files	Info	Warnings	Errors
236	10	42	0

Files

File	I	W	E
nl/tudelft/simulation/dsol/experiment/ExperimentReplication.java	0	1	0
nl/tudelft/simulation/dsol/experiment/RunControl.java	0	3	0
nl/tudelft/simulation/dsol/formalisms/Resource.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/AbstractDevsModel.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/AbstractDevsPortModel.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/AbstractEntity.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/AtomicModel.java	0	3	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/CoupledModel.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/DoubleCompare.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/ExternalInputCoupling.java	1	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/ExternalOutputCoupling.java	1	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/InputPort.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/InputPortInterface.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/InternalCoupling.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/OutputPort.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/OutputPortInterface.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/Phase.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/exceptions/PortAlreadyDefinedException.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/exceptions/PortNotFoundException.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/exceptions/StateVariableNotFoundException.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/exceptions/package-info.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/devs/esdevs/package-info.java	0	1	0
nl/tudelft/simulation/dsol/formalisms/flow/Entity.java	0	7	0
nl/tudelft/simulation/dsol/model/AbstractDsolModel.java	1	0	0
nl/tudelft/simulation/dsol/simtime/SimTime.java	1	5	0
nl/tudelft/simulation/dsol/simulators/DevsRealTimeAnimator.java	0	2	0
nl/tudelft/simulation/dsol/simulators/DevsSimulatorInterface.java	6	0	0
nl/tudelft/simulation/dsol/simulators/Simulator.java	0	2	0

Rules

Category	Rule	Violations	Severity
blocks	NeedBraces	9	Warning
coding	EmptyStatement	1	Warning
	HiddenField ignoreConstructorParameter: "true" ignoreSetter: "true"	2	Warning
design	VisibilityModifier	1	Warning
javadoc	JavadocPackage	1	Info
misc	NewlineAtEndOfFile fileExtensions: "java" lineSeparator: "crlf"	20	Warning
	TodoComment	1	Warning
modifier	RedundantModifier	1	Warning
naming	ConstantName	5	Warning
sizes	LineLength max: "128"	9	Info
whitespace	WhitespaceAfter	2	Warning

Details

nl/tudelft/simulation/dsol/experiment/ExperimentReplication.java

Severity	Category	Rule	Message	Line
Warning	design	VisibilityModifier	Variable 'replicationNr' must be private and have accessor methods.	34

nl/tudelft/simulation/dsol/experiment/RunControl.java

Severity	Category	Rule	Message	Line
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	121
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	123
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	125

nl/tudelft/simulation/dsol/formalisms/Resource.java

Severity	Category	Rule	Message	Line
Warning	coding	EmptyStatement	Empty statement.	96

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/AbstractDevsModel.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/AbstractDevsPortModel.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/AbstractEntity.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/AtomicModel.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1
Warning	whitespace	WhitespaceAfter	',' is not followed by whitespace.	173
Warning	whitespace	WhitespaceAfter	',' is not followed by whitespace.	216

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/CoupledModel.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/DoubleCompare.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/ExternalInputCoupling.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1
Info	sizes	LineLength	Line is longer than 128 characters (found 129).	31

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/ExternalOutputCoupling.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1
Info	sizes	LineLength	Line is longer than 128 characters (found 132).	31

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/InputPort.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/InputPortInterface.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/InternalCoupling.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/OutputPort.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/OutputPortInterface.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/Phase.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/exceptions/PortAlreadyDefinedException.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/exceptions/PortNotFoundException.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/exceptions/StateVariableNotFoundException.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/exceptions/package-info.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1

nl/tudelft/simulation/dsol/formalisms/devs/esdevs/package-info.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1

nl/tudelft/simulation/dsol/formalisms/flow/Entity.java

Severity	Category	Rule	Message	Line
Warning	misc	NewlineAtEndOfFile	File does not end with a newline.	1
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	71
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	84
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	96
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	108
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	120
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	132

nl/tudelft/simulation/dsol/model/AbstractDsolModel.java

Severity	Category	Rule	Message	Line
Info	sizes	LineLength	Line is longer than 128 characters (found 133).	28

nl/tudelft/simulation/dsol/simtime/SimTime.java

Severity	Category	Rule	Message	Line
Info	javadoc	JavadocPackage	Missing package-info.java file.	1
Warning	naming	ConstantName	Name 'hashDouble' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.	21
Warning	naming	ConstantName	Name 'hashFloat' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.	24
Warning	naming	ConstantName	Name 'hashLong' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.	27
Warning	naming	ConstantName	Name 'hashDuration' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.	30
Warning	naming	ConstantName	Name 'hashFloatDuration' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.	33

nl/tudelft/simulation/dsol/simulators/DevsRealTimeAnimator.java

Severity	Category	Rule	Message	Line
Warning	misc	TodoComment	Comment matches to-do format 'TODO:'.	34
Warning	modifier	RedundantModifier	Redundant 'final' modifier.	73

nl/tudelft/simulation/dsol/simulators/DevsSimulatorInterface.java

Severity	Category	Rule	Message	Line
Info	sizes	LineLength	Line is longer than 128 characters (found 157).	214
Info	sizes	LineLength	Line is longer than 128 characters (found 156).	232
Info	sizes	LineLength	Line is longer than 128 characters (found 156).	251
Info	sizes	LineLength	Line is longer than 128 characters (found 155).	269
Info	sizes	LineLength	Line is longer than 128 characters (found 155).	287
Info	sizes	LineLength	Line is longer than 128 characters (found 133).	304

nl/tudelft/simulation/dsol/simulators/Simulator.java

Severity	Category	Rule	Message	Line
Warning	coding	HiddenField	'model' hides a field.	107
Warning	coding	HiddenField	'replication' hides a field.	107