Checkstyle Results

The following document contains the results of Checkstyle 12.1.1 with /config/dsol-checks.xml ruleset.

Summary

Files  Info  Warnings  Errors
17 0 73 0

Files

File  I  W  E
nl/tudelft/simulation/dsol/formalisms/flow/AbstractFlowModel.java 0 3 0
nl/tudelft/simulation/dsol/formalisms/flow/Block.java 0 1 0
nl/tudelft/simulation/dsol/formalisms/flow/CapacityRequest.java 0 5 0
nl/tudelft/simulation/dsol/formalisms/flow/CapacityRequestor.java 0 2 0
nl/tudelft/simulation/dsol/formalisms/flow/Create.java 0 8 0
nl/tudelft/simulation/dsol/formalisms/flow/Delay.java 0 2 0
nl/tudelft/simulation/dsol/formalisms/flow/Duplicate.java 0 6 0
nl/tudelft/simulation/dsol/formalisms/flow/Entity.java 0 6 0
nl/tudelft/simulation/dsol/formalisms/flow/FlowBlock.java 0 9 0
nl/tudelft/simulation/dsol/formalisms/flow/FlowModel.java 0 2 0
nl/tudelft/simulation/dsol/formalisms/flow/Queue.java 0 6 0
nl/tudelft/simulation/dsol/formalisms/flow/Release.java 0 6 0
nl/tudelft/simulation/dsol/formalisms/flow/Resource.java 0 7 0
nl/tudelft/simulation/dsol/formalisms/flow/Seize.java 0 10 0

Rules

Category Rule Violations Severity
blocks NeedBraces 26  Warning
coding HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
27  Warning
design VisibilityModifier 9  Warning
javadoc JavadocStyle 3  Warning
modifier RedundantModifier 6  Warning
naming ConstantName 2  Warning

Details

nl/tudelft/simulation/dsol/formalisms/flow/AbstractFlowModel.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'countMap' must be private and have accessor methods. 31
 Warning design VisibilityModifier Variable 'blockMap' must be private and have accessor methods. 34
 Warning design VisibilityModifier Variable 'blockNamingType' must be private and have accessor methods. 37

nl/tudelft/simulation/dsol/formalisms/flow/Block.java

Severity Category Rule Message Line
 Warning naming ConstantName Name 'blockNumberCounter' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 36

nl/tudelft/simulation/dsol/formalisms/flow/CapacityRequest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'amount' must be private and have accessor methods. 24
 Warning javadoc JavadocStyle First sentence should end with a period. 83
 Warning blocks NeedBraces 'if' construct must use '{}'s. 112
 Warning blocks NeedBraces 'if' construct must use '{}'s. 114
 Warning blocks NeedBraces 'if' construct must use '{}'s. 116

nl/tudelft/simulation/dsol/formalisms/flow/CapacityRequestor.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 23
 Warning modifier RedundantModifier Redundant 'public' modifier. 39

nl/tudelft/simulation/dsol/formalisms/flow/Create.java

Severity Category Rule Message Line
 Warning coding HiddenField 'entitySupplier' hides a field. 123
 Warning coding HiddenField 'startTimeDist' hides a field. 140
 Warning coding HiddenField 'startTime' hides a field. 161
 Warning coding HiddenField 'intervalDist' hides a field. 180
 Warning coding HiddenField 'batchSizeDist' hides a field. 214
 Warning coding HiddenField 'maxNumberCreationEvents' hides a field. 226
 Warning coding HiddenField 'maxNumberGeneratedEntities' hides a field. 237
 Warning coding HiddenField 'endTime' hides a field. 250

nl/tudelft/simulation/dsol/formalisms/flow/Delay.java

Severity Category Rule Message Line
 Warning coding HiddenField 'delayDistribution' hides a field. 62
 Warning coding HiddenField 'delayFunction' hides a field. 73

nl/tudelft/simulation/dsol/formalisms/flow/Duplicate.java

Severity Category Rule Message Line
 Warning coding HiddenField 'duplicateDestination' hides a field. 62
 Warning coding HiddenField 'numberCopiesDist' hides a field. 73
 Warning coding HiddenField 'duplicateReleaseFunction' hides a field. 98
 Warning blocks NeedBraces 'if' construct must use '{}'s. 116
 Warning blocks NeedBraces 'if' construct must use '{}'s. 118
 Warning javadoc JavadocStyle First sentence should end with a period. 148

nl/tudelft/simulation/dsol/formalisms/flow/Entity.java

Severity Category Rule Message Line
 Warning naming ConstantName Name 'cloner' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 42
 Warning blocks NeedBraces 'if' construct must use '{}'s. 79
 Warning blocks NeedBraces 'if' construct must use '{}'s. 92
 Warning blocks NeedBraces 'if' construct must use '{}'s. 104
 Warning blocks NeedBraces 'if' construct must use '{}'s. 119
 Warning blocks NeedBraces 'if' construct must use '{}'s. 151

nl/tudelft/simulation/dsol/formalisms/flow/FlowBlock.java

Severity Category Rule Message Line
 Warning coding HiddenField 'receiveFunction' hides a field. 88
 Warning coding HiddenField 'releaseFunction' hides a field. 100
 Warning blocks NeedBraces 'if' construct must use '{}'s. 114
 Warning coding HiddenField 'destination' hides a field. 125
 Warning blocks NeedBraces 'if' construct must use '{}'s. 168
 Warning blocks NeedBraces 'if' construct must use '{}'s. 183
 Warning blocks NeedBraces 'if' construct must use '{}'s. 198
 Warning blocks NeedBraces 'if' construct must use '{}'s. 230
 Warning javadoc JavadocStyle First sentence should end with a period. 273

nl/tudelft/simulation/dsol/formalisms/flow/FlowModel.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'final' modifier. 33
 Warning modifier RedundantModifier Redundant 'public' modifier. 36

nl/tudelft/simulation/dsol/formalisms/flow/Queue.java

Severity Category Rule Message Line
 Warning blocks NeedBraces 'if' construct must use '{}'s. 202
 Warning blocks NeedBraces 'if' construct must use '{}'s. 219
 Warning blocks NeedBraces 'if' construct must use '{}'s. 237
 Warning blocks NeedBraces 'if' construct must use '{}'s. 239
 Warning blocks NeedBraces 'if' construct must use '{}'s. 257
 Warning blocks NeedBraces 'if' construct must use '{}'s. 259

nl/tudelft/simulation/dsol/formalisms/flow/Release.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'resource' must be private and have accessor methods. 70
 Warning coding HiddenField 'fixedCapacityRelease' hides a field. 97
 Warning coding HiddenField 'capacityReleaseFunction' hides a field. 113
 Warning design VisibilityModifier Variable 'resource' must be private and have accessor methods. 168
 Warning coding HiddenField 'fixedCapacityRelease' hides a field. 195
 Warning coding HiddenField 'capacityReleaseFunction' hides a field. 211

nl/tudelft/simulation/dsol/formalisms/flow/Resource.java

Severity Category Rule Message Line
 Warning coding HiddenField 'releaseType' hides a field. 69
 Warning blocks NeedBraces 'if' construct must use '{}'s. 190
 Warning blocks NeedBraces 'if' construct must use '{}'s. 266
 Warning blocks NeedBraces 'else' construct must use '{}'s. 268
 Warning blocks NeedBraces 'if' construct must use '{}'s. 428
 Warning blocks NeedBraces 'else' construct must use '{}'s. 430
 Warning modifier RedundantModifier Redundant 'static' modifier. 464

nl/tudelft/simulation/dsol/formalisms/flow/Seize.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'storage' must be private and have accessor methods. 40
 Warning design VisibilityModifier Variable 'resource' must be private and have accessor methods. 136
 Warning coding HiddenField 'fixedCapacityClaim' hides a field. 163
 Warning coding HiddenField 'capacityClaimFunction' hides a field. 179
 Warning coding HiddenField 'resource' hides a field. 233
 Warning design VisibilityModifier Variable 'resource' must be private and have accessor methods. 261
 Warning coding HiddenField 'fixedCapacityClaim' hides a field. 288
 Warning coding HiddenField 'capacityClaimFunction' hides a field. 304
 Warning coding HiddenField 'resource' hides a field. 358
 Warning modifier RedundantModifier Redundant 'static' modifier. 385