Checkstyle Results
The following document contains the results of Checkstyle 10.17.0 with /config/dsol-checks.xml ruleset.
Summary
Files | Info | Warnings | Errors |
---|---|---|---|
122 | 24 | 103 | 16 |
Files
Rules
Category | Rule | Violations | Severity |
---|---|---|---|
blocks | AvoidNestedBlocks
|
1 | Warning |
NeedBraces | 27 | Warning | |
coding | HiddenField
|
5 | Warning |
design | DesignForExtension | 1 | Warning |
HideUtilityClassConstructor | 1 | Warning | |
VisibilityModifier | 35 | Warning | |
imports | UnusedImports | 1 | Warning |
javadoc | JavadocPackage | 8 | Info |
JavadocStyle
|
16 | Error | |
misc | FinalParameters | 2 | Warning |
NewlineAtEndOfFile
|
16 | Warning | |
TodoComment | 5 | Warning | |
modifier | RedundantModifier | 3 | Warning |
naming | MemberName | 4 | Warning |
sizes | LineLength
|
16 | Info |
whitespace | WhitespaceAfter | 2 | Warning |
Details
nl/tudelft/simulation/dsol/swing/animation/d2/AnimationPanel.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
nl/tudelft/simulation/dsol/swing/animation/d2/AnimationUpdaterThread.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
Warning | misc | TodoComment | Comment matches to-do format 'TODO:'. | 90 |
nl/tudelft/simulation/dsol/swing/animation/d2/AutoPanAnimationPanel.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
Warning | misc | TodoComment | Comment matches to-do format 'TODO:'. | 85 |
Warning | misc | TodoComment | Comment matches to-do format 'TODO:'. | 129 |
Warning | blocks | AvoidNestedBlocks | Avoid nested blocks. | 131 |
nl/tudelft/simulation/dsol/swing/animation/d2/InputListener.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
nl/tudelft/simulation/dsol/swing/animation/d2/VisualizationPanel.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
Warning | coding | HiddenField | 'extent' hides a field. | 842 |
nl/tudelft/simulation/dsol/swing/animation/d2/actions/HomeAction.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
nl/tudelft/simulation/dsol/swing/animation/d2/actions/IntrospectionAction.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
nl/tudelft/simulation/dsol/swing/animation/d2/actions/PanDownAction.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
nl/tudelft/simulation/dsol/swing/animation/d2/actions/PanLeftAction.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
nl/tudelft/simulation/dsol/swing/animation/d2/actions/PanRightAction.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
nl/tudelft/simulation/dsol/swing/animation/d2/actions/PanUpAction.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
nl/tudelft/simulation/dsol/swing/animation/d2/actions/ShowGridAction.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
nl/tudelft/simulation/dsol/swing/animation/d2/actions/ZoomInAction.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
nl/tudelft/simulation/dsol/swing/animation/d2/actions/ZoomOutAction.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
nl/tudelft/simulation/dsol/swing/animation/d2/actions/package-info.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
nl/tudelft/simulation/dsol/swing/animation/d2/package-info.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
nl/tudelft/simulation/dsol/swing/charts/boxwhisker/BoxAndWhiskerPlot.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Info | javadoc | JavadocPackage | Missing package-info.java file. | 1 |
Warning | design | VisibilityModifier | Variable 'tallies' must be private and have accessor methods. | 59 |
Warning | design | VisibilityModifier | Variable 'formatter' must be private and have accessor methods. | 62 |
Warning | design | VisibilityModifier | Variable 'confidenceInterval' must be private and have accessor methods. | 65 |
nl/tudelft/simulation/dsol/swing/charts/histogram/Histogram.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | design | VisibilityModifier | Variable 'chart' must be private and have accessor methods. | 54 |
Warning | design | VisibilityModifier | Variable 'dataset' must be private and have accessor methods. | 57 |
nl/tudelft/simulation/dsol/swing/charts/histogram/HistogramDataset.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | design | VisibilityModifier | Variable 'domain' must be private and have accessor methods. | 34 |
Warning | design | VisibilityModifier | Variable 'range' must be private and have accessor methods. | 37 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 39 |
Warning | design | VisibilityModifier | Variable 'numberOfBins' must be private and have accessor methods. | 40 |
Warning | design | VisibilityModifier | Variable 'series' must be private and have accessor methods. | 43 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 72 |
nl/tudelft/simulation/dsol/swing/charts/histogram/HistogramDomainAxis.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Info | javadoc | JavadocPackage | Missing package-info.java file. | 1 |
Warning | design | VisibilityModifier | Variable 'labels' must be private and have accessor methods. | 39 |
Warning | design | VisibilityModifier | Variable 'maxLabelHeight' must be private and have accessor methods. | 42 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 105 |
nl/tudelft/simulation/dsol/swing/charts/xy/XYChart.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | design | VisibilityModifier | Variable 'chart' must be private and have accessor methods. | 65 |
Warning | design | VisibilityModifier | Variable 'simulator' must be private and have accessor methods. | 68 |
Warning | design | VisibilityModifier | Variable 'dataset' must be private and have accessor methods. | 71 |
Warning | design | VisibilityModifier | Variable 'axisType' must be private and have accessor methods. | 74 |
nl/tudelft/simulation/dsol/swing/charts/xy/XYDataset.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | javadoc | JavadocStyle | First sentence should end with a period. | 54 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 125 |
nl/tudelft/simulation/dsol/swing/charts/xy/XYSeries.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Info | javadoc | JavadocPackage | Missing package-info.java file. | 1 |
Warning | design | VisibilityModifier | Variable 'entries' must be private and have accessor methods. | 46 |
Warning | naming | MemberName | Name 'PERIOD' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 58 |
Warning | misc | FinalParameters | Parameter item should be final. | 158 |
Warning | misc | FinalParameters | Parameter item should be final. | 169 |
nl/tudelft/simulation/dsol/swing/gui/LabeledPanel.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Info | javadoc | JavadocPackage | Missing package-info.java file. | 1 |
nl/tudelft/simulation/dsol/swing/gui/TablePanel.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 84 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 86 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 88 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 90 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 102 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 104 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 106 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 108 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 110 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 112 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 114 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 116 |
nl/tudelft/simulation/dsol/swing/gui/animation/AnimationToggles.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Info | sizes | LineLength | Line is longer than 128 characters (found 130). | 7 |
nl/tudelft/simulation/dsol/swing/gui/control/AbstractControlPanel.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Info | sizes | LineLength | Line is longer than 128 characters (found 138). | 105 |
Warning | misc | TodoComment | Comment matches to-do format 'TODO:'. | 298 |
nl/tudelft/simulation/dsol/swing/gui/control/DevsControlPanel.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 85 |
Warning | whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 168 |
Info | sizes | LineLength | Line is longer than 128 characters (found 134). | 232 |
Info | sizes | LineLength | Line is longer than 128 characters (found 133). | 266 |
Info | sizes | LineLength | Line is longer than 128 characters (found 132). | 300 |
Info | sizes | LineLength | Line is longer than 128 characters (found 131). | 334 |
Info | sizes | LineLength | Line is longer than 128 characters (found 131). | 368 |
nl/tudelft/simulation/dsol/swing/gui/control/GenericControlPanel.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Info | sizes | LineLength | Line is longer than 128 characters (found 130). | 65 |
Info | sizes | LineLength | Line is longer than 128 characters (found 129). | 99 |
Info | sizes | LineLength | Line is longer than 128 characters (found 132). | 203 |
nl/tudelft/simulation/dsol/swing/gui/control/RealTimeControlPanel.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | misc | TodoComment | Comment matches to-do format 'TODO:'. | 132 |
Info | sizes | LineLength | Line is longer than 128 characters (found 131). | 202 |
Info | sizes | LineLength | Line is longer than 128 characters (found 130). | 237 |
Info | sizes | LineLength | Line is longer than 128 characters (found 134). | 272 |
Info | sizes | LineLength | Line is longer than 128 characters (found 134). | 307 |
nl/tudelft/simulation/dsol/swing/gui/inputparameters/Test.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 28 |
nl/tudelft/simulation/dsol/swing/gui/util/Icons.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | modifier | RedundantModifier | Redundant 'final' modifier. | 33 |
Warning | modifier | RedundantModifier | Redundant 'final' modifier. | 51 |
nl/tudelft/simulation/dsol/swing/gui/util/RegexFormatter.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | design | DesignForExtension | Class 'RegexFormatter' looks like designed for extension (can be subclassed), but the method 'stringToValue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RegexFormatter' final or making the method 'stringToValue' static/final/abstract/empty, or adding allowed annotation for the method. | 38 |
nl/tudelft/simulation/dsol/swing/introspection/gui/CollectionTableModel.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | design | VisibilityModifier | Variable 'instances' must be private and have accessor methods. | 45 |
Warning | design | VisibilityModifier | Variable 'keys' must be private and have accessor methods. | 48 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 59 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 200 |
Warning | coding | HiddenField | 'manager' hides a field. | 335 |
nl/tudelft/simulation/dsol/swing/introspection/gui/DefaultModelManager.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | design | VisibilityModifier | Variable 'defaultObjectTableModel' must be private and have accessor methods. | 18 |
Warning | design | VisibilityModifier | Variable 'defaultCollectionObjectTableModel' must be private and have accessor methods. | 21 |
Warning | design | VisibilityModifier | Variable 'defaultMapObjectTableModel' must be private and have accessor methods. | 24 |
nl/tudelft/simulation/dsol/swing/introspection/gui/ExpandButton.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | javadoc | JavadocStyle | First sentence should end with a period. | 43 |
Warning | naming | MemberName | Name 'PROPERTY' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 44 |
Warning | naming | MemberName | Name 'MODEL' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 47 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 183 |
nl/tudelft/simulation/dsol/swing/introspection/gui/ImmutableCollectionTableModel.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Info | javadoc | JavadocPackage | Missing package-info.java file. | 1 |
Warning | design | VisibilityModifier | Variable 'instances' must be private and have accessor methods. | 41 |
Warning | design | VisibilityModifier | Variable 'keys' must be private and have accessor methods. | 44 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 52 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 186 |
Warning | coding | HiddenField | 'manager' hides a field. | 253 |
nl/tudelft/simulation/dsol/swing/introspection/gui/MapTableModel.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | design | VisibilityModifier | Variable 'keyMap' must be private and have accessor methods. | 36 |
Warning | design | VisibilityModifier | Variable 'valueMap' must be private and have accessor methods. | 39 |
Warning | design | VisibilityModifier | Variable 'rowKeys' must be private and have accessor methods. | 42 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 50 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 187 |
Warning | coding | HiddenField | 'manager' hides a field. | 259 |
nl/tudelft/simulation/dsol/swing/introspection/gui/ObjectJTable.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | design | VisibilityModifier | Variable 'hasShown' must be private and have accessor methods. | 55 |
Warning | naming | MemberName | Name 'CONFIG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 63 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 146 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 148 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 150 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 152 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 154 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 156 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 158 |
nl/tudelft/simulation/dsol/swing/introspection/gui/ObjectTableModel.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Info | sizes | LineLength | Line is longer than 128 characters (found 143). | 16 |
Warning | design | VisibilityModifier | Variable 'properties' must be private and have accessor methods. | 28 |
Warning | coding | HiddenField | 'manager' hides a field. | 220 |
nl/tudelft/simulation/dsol/swing/introspection/gui/UpdateTimer.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Info | sizes | LineLength | Line is longer than 128 characters (found 143). | 14 |
nl/tudelft/simulation/dsol/swing/introspection/mapping/CellPresentationConfiguration.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | javadoc | JavadocStyle | First sentence should end with a period. | 20 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 27 |
nl/tudelft/simulation/dsol/swing/introspection/mapping/DefaultConfiguration.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | imports | UnusedImports | Unused import - java.awt.Component. | 4 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 69 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 79 |
nl/tudelft/simulation/dsol/swing/introspection/mapping/ImmutableMapRenderer.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | blocks | NeedBraces | 'else' construct must use '{}'s. | 47 |
nl/tudelft/simulation/dsol/swing/introspection/mapping/MyColorEditor.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | design | VisibilityModifier | Variable 'color' must be private and have accessor methods. | 35 |
Warning | design | VisibilityModifier | Variable 'cellPanel' must be private and have accessor methods. | 38 |
nl/tudelft/simulation/dsol/swing/introspection/mapping/MyTableCellEditor.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Info | javadoc | JavadocPackage | Missing package-info.java file. | 1 |
nl/tudelft/simulation/dsol/swing/introspection/sortable/Sortable.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | modifier | RedundantModifier | Redundant 'public' modifier. | 22 |
nl/tudelft/simulation/dsol/swing/introspection/sortable/SortingHeaderCell.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | design | VisibilityModifier | Variable 'instanceCounter' must be private and have accessor methods. | 39 |
nl/tudelft/simulation/dsol/swing/introspection/sortable/SortingTableHeader.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Info | javadoc | JavadocPackage | Missing package-info.java file. | 1 |
Warning | design | VisibilityModifier | Variable 'definitions' must be private and have accessor methods. | 35 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 66 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 72 |
Warning | blocks | NeedBraces | 'if' construct must use '{}'s. | 76 |
Warning | blocks | NeedBraces | 'else' construct must use '{}'s. | 78 |
nl/tudelft/simulation/dsol/swing/introspection/sortable/SortingTableModel.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Warning | design | VisibilityModifier | Variable 'proxyListeners' must be private and have accessor methods. | 36 |
Warning | design | VisibilityModifier | Variable 'source' must be private and have accessor methods. | 39 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 41 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 44 |
Warning | design | VisibilityModifier | Variable 'expandedIndex' must be private and have accessor methods. | 45 |
nl/tudelft/simulation/dsol/swing/introspection/table/DynamicTableModel.java
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Info | javadoc | JavadocPackage | Missing package-info.java file. | 1 |