Checkstyle Results
The following document contains the results of Checkstyle 12.1.1 with /config/dsol-checks.xml ruleset.
Summary
| Files | |||
|---|---|---|---|
| 123 | 8 | 134 | 0 |
Files
Rules
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | AvoidNestedBlocks
|
1 | |
| NeedBraces | 53 | ||
| coding | HiddenField
|
7 | |
| design | HideUtilityClassConstructor | 1 | |
| VisibilityModifier | 39 | ||
| imports | UnusedImports | 2 | |
| javadoc | JavadocPackage | 8 | |
| JavadocStyle | 18 | ||
| misc | FinalParameters | 2 | |
| TodoComment | 4 | ||
| modifier | RedundantModifier | 3 | |
| naming | MemberName | 4 |
Details
nl/tudelft/simulation/dsol/swing/animation/d2/AnimationUpdaterThread.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | TodoComment | Comment matches to-do format 'TODO:'. | 76 |
nl/tudelft/simulation/dsol/swing/animation/d2/AutoPanAnimationPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | TodoComment | Comment matches to-do format 'TODO:'. | 80 | |
| misc | TodoComment | Comment matches to-do format 'TODO:'. | 121 | |
| blocks | AvoidNestedBlocks | Avoid nested blocks. | 123 |
nl/tudelft/simulation/dsol/swing/animation/d2/InputListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| blocks | NeedBraces | 'if' construct must use '{}'s. | 113 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 115 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 117 | |
| blocks | NeedBraces | 'else' construct must use '{}'s. | 119 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 124 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 126 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 128 | |
| blocks | NeedBraces | 'else' construct must use '{}'s. | 130 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 196 | |
| blocks | NeedBraces | 'else' construct must use '{}'s. | 198 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 203 | |
| blocks | NeedBraces | 'else' construct must use '{}'s. | 205 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 209 |
nl/tudelft/simulation/dsol/swing/animation/d2/VisualizationPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | VisibilityModifier | Variable 'rotation' must be private and have accessor methods. | 126 | |
| design | VisibilityModifier | Variable 'lastRotation' must be private and have accessor methods. | 129 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 573 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 783 | |
| coding | HiddenField | 'extent' hides a field. | 788 | |
| coding | HiddenField | 'extent' hides a field. | 992 |
nl/tudelft/simulation/dsol/swing/charts/boxwhisker/BoxAndWhiskerPlot.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| design | VisibilityModifier | Variable 'tallies' must be private and have accessor methods. | 57 | |
| design | VisibilityModifier | Variable 'formatter' must be private and have accessor methods. | 60 | |
| design | VisibilityModifier | Variable 'confidenceInterval' must be private and have accessor methods. | 63 |
nl/tudelft/simulation/dsol/swing/charts/histogram/Histogram.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | VisibilityModifier | Variable 'chart' must be private and have accessor methods. | 49 | |
| design | VisibilityModifier | Variable 'dataset' must be private and have accessor methods. | 52 |
nl/tudelft/simulation/dsol/swing/charts/histogram/HistogramDataset.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | VisibilityModifier | Variable 'domain' must be private and have accessor methods. | 33 | |
| design | VisibilityModifier | Variable 'range' must be private and have accessor methods. | 36 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 38 | |
| design | VisibilityModifier | Variable 'numberOfBins' must be private and have accessor methods. | 39 | |
| design | VisibilityModifier | Variable 'series' must be private and have accessor methods. | 42 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 71 |
nl/tudelft/simulation/dsol/swing/charts/histogram/HistogramDomainAxis.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| design | VisibilityModifier | Variable 'labels' must be private and have accessor methods. | 38 | |
| design | VisibilityModifier | Variable 'maxLabelHeight' must be private and have accessor methods. | 41 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 101 |
nl/tudelft/simulation/dsol/swing/charts/xy/XYChart.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | VisibilityModifier | Variable 'chart' must be private and have accessor methods. | 60 | |
| design | VisibilityModifier | Variable 'simulator' must be private and have accessor methods. | 63 | |
| design | VisibilityModifier | Variable 'dataset' must be private and have accessor methods. | 66 | |
| design | VisibilityModifier | Variable 'axisType' must be private and have accessor methods. | 69 |
nl/tudelft/simulation/dsol/swing/charts/xy/XYDataset.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocStyle | First sentence should end with a period. | 52 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 116 |
nl/tudelft/simulation/dsol/swing/charts/xy/XYSeries.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| design | VisibilityModifier | Variable 'entries' must be private and have accessor methods. | 45 | |
| naming | MemberName | Name 'PERIOD' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 57 | |
| misc | FinalParameters | Parameter item should be final. | 156 | |
| misc | FinalParameters | Parameter item should be final. | 167 |
nl/tudelft/simulation/dsol/swing/gui/ConsoleOutput.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| coding | HiddenField | 'font' hides a field. | 81 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 220 |
nl/tudelft/simulation/dsol/swing/gui/LoggerConsole.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| design | VisibilityModifier | Variable 'appender' must be private and have accessor methods. | 57 |
nl/tudelft/simulation/dsol/swing/gui/TablePanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| blocks | NeedBraces | 'if' construct must use '{}'s. | 83 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 85 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 87 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 89 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 101 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 103 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 105 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 107 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 109 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 111 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 113 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 115 |
nl/tudelft/simulation/dsol/swing/gui/animation/panel/PropertiesPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | UnusedImports | Unused import - java.rmi.RemoteException. | 3 |
nl/tudelft/simulation/dsol/swing/gui/animation/panel/SearchPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | UnusedImports | Unused import - java.rmi.RemoteException. | 8 |
nl/tudelft/simulation/dsol/swing/gui/control/AbstractControlPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| blocks | NeedBraces | 'while' construct must use '{}'s. | 301 |
nl/tudelft/simulation/dsol/swing/gui/control/RealTimeControlPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | TodoComment | Comment matches to-do format 'TODO:'. | 152 |
nl/tudelft/simulation/dsol/swing/gui/control/RunSpeedSliderPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | VisibilityModifier | Variable 'slider' must be private and have accessor methods. | 39 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 67 | |
| blocks | NeedBraces | 'for' construct must use '{}'s. | 112 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 147 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 184 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 186 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 188 |
nl/tudelft/simulation/dsol/swing/gui/control/SpeedPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| blocks | NeedBraces | 'if' construct must use '{}'s. | 419 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 421 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 423 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 425 | |
| blocks | NeedBraces | 'else' construct must use '{}'s. | 427 |
nl/tudelft/simulation/dsol/swing/gui/inputparameters/Test.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 28 |
nl/tudelft/simulation/dsol/swing/gui/util/Icons.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| modifier | RedundantModifier | Redundant 'final' modifier. | 35 | |
| modifier | RedundantModifier | Redundant 'final' modifier. | 53 |
nl/tudelft/simulation/dsol/swing/introspection/gui/CollectionTableModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | VisibilityModifier | Variable 'instances' must be private and have accessor methods. | 44 | |
| design | VisibilityModifier | Variable 'keys' must be private and have accessor methods. | 47 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 58 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 193 | |
| coding | HiddenField | 'manager' hides a field. | 321 |
nl/tudelft/simulation/dsol/swing/introspection/gui/DefaultModelManager.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | VisibilityModifier | Variable 'defaultObjectTableModel' must be private and have accessor methods. | 17 | |
| design | VisibilityModifier | Variable 'defaultCollectionObjectTableModel' must be private and have accessor methods. | 20 | |
| design | VisibilityModifier | Variable 'defaultMapObjectTableModel' must be private and have accessor methods. | 23 |
nl/tudelft/simulation/dsol/swing/introspection/gui/ExpandButton.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocStyle | First sentence should end with a period. | 42 | |
| naming | MemberName | Name 'PROPERTY' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 43 | |
| naming | MemberName | Name 'MODEL' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 46 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 182 |
nl/tudelft/simulation/dsol/swing/introspection/gui/ImmutableCollectionTableModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| design | VisibilityModifier | Variable 'instances' must be private and have accessor methods. | 37 | |
| design | VisibilityModifier | Variable 'keys' must be private and have accessor methods. | 40 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 48 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 176 | |
| coding | HiddenField | 'manager' hides a field. | 240 |
nl/tudelft/simulation/dsol/swing/introspection/gui/MapTableModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | VisibilityModifier | Variable 'keyMap' must be private and have accessor methods. | 32 | |
| design | VisibilityModifier | Variable 'valueMap' must be private and have accessor methods. | 35 | |
| design | VisibilityModifier | Variable 'rowKeys' must be private and have accessor methods. | 38 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 46 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 177 | |
| coding | HiddenField | 'manager' hides a field. | 246 |
nl/tudelft/simulation/dsol/swing/introspection/gui/ObjectJTable.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | VisibilityModifier | Variable 'hasShown' must be private and have accessor methods. | 51 | |
| naming | MemberName | Name 'CONFIG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 59 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 141 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 143 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 145 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 147 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 149 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 151 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 153 |
nl/tudelft/simulation/dsol/swing/introspection/gui/ObjectTableModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | VisibilityModifier | Variable 'properties' must be private and have accessor methods. | 26 | |
| coding | HiddenField | 'manager' hides a field. | 208 |
nl/tudelft/simulation/dsol/swing/introspection/mapping/CellPresentationConfiguration.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocStyle | First sentence should end with a period. | 19 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 26 |
nl/tudelft/simulation/dsol/swing/introspection/mapping/DefaultConfiguration.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocStyle | First sentence should end with a period. | 67 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 77 |
nl/tudelft/simulation/dsol/swing/introspection/mapping/ImmutableMapRenderer.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| blocks | NeedBraces | 'else' construct must use '{}'s. | 42 |
nl/tudelft/simulation/dsol/swing/introspection/mapping/MyColorEditor.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | VisibilityModifier | Variable 'color' must be private and have accessor methods. | 31 | |
| design | VisibilityModifier | Variable 'cellPanel' must be private and have accessor methods. | 34 |
nl/tudelft/simulation/dsol/swing/introspection/mapping/MyTableCellEditor.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocPackage | Missing package-info.java file. | 1 |
nl/tudelft/simulation/dsol/swing/introspection/sortable/Sortable.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| modifier | RedundantModifier | Redundant 'public' modifier. | 21 |
nl/tudelft/simulation/dsol/swing/introspection/sortable/SortingHeaderCell.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | VisibilityModifier | Variable 'instanceCounter' must be private and have accessor methods. | 38 |
nl/tudelft/simulation/dsol/swing/introspection/sortable/SortingTableHeader.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| design | VisibilityModifier | Variable 'definitions' must be private and have accessor methods. | 31 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 61 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 67 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 71 | |
| blocks | NeedBraces | 'else' construct must use '{}'s. | 73 |
nl/tudelft/simulation/dsol/swing/introspection/sortable/SortingTableModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | VisibilityModifier | Variable 'proxyListeners' must be private and have accessor methods. | 33 | |
| design | VisibilityModifier | Variable 'source' must be private and have accessor methods. | 36 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 38 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 41 | |
| design | VisibilityModifier | Variable 'expandedIndex' must be private and have accessor methods. | 42 |
nl/tudelft/simulation/dsol/swing/introspection/table/DynamicTableModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocPackage | Missing package-info.java file. | 1 |
