Checkstyle Results
The following document contains the results of Checkstyle 12.1.1 with /config/dsol-checks.xml ruleset.
Summary
| Files |  Info |
 Warnings |
 Errors |
|---|---|---|---|
| 17 | 4 | 177 | 0 |
Files
Rules
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | EmptyBlock | 4 | Warning |
LeftCurly
|
24 | Warning | |
| NeedBraces | 78 | Warning | |
RightCurly
|
13 | Warning | |
| coding | HiddenField
|
4 | Warning |
| design | HideUtilityClassConstructor | 2 | Warning |
| VisibilityModifier | 21 | Warning | |
| imports | UnusedImports | 1 | Warning |
| javadoc | JavadocStyle | 6 | Warning |
| misc | FinalParameters | 15 | Warning |
| TodoComment | 7 | Warning | |
| naming | ParameterName | 2 | Warning |
| sizes | MethodLength | 2 | Info |
| ParameterNumber | 2 | Info |
Details
nl/tudelft/simulation/dsol/web/AbstractTestDemoServer.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'sessionModelMap' must be private and have accessor methods. | 65 |
| Warning |
design | VisibilityModifier | Variable 'sessionWebModelMap' must be private and have accessor methods. | 68 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 162 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 164 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 374 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 376 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 391 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 393 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 399 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 403 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 407 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 411 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 539 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 544 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 557 |
nl/tudelft/simulation/dsol/web/Cat.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 16 |
nl/tudelft/simulation/dsol/web/DsolWebModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - java.rmi.RemoteException. | 6 |
| Warning |
blocks | RightCurly | '}' at column 24 should be alone on a line. | 136 |
| Warning |
blocks | RightCurly | '}' at column 24 should be alone on a line. | 148 |
| Warning |
blocks | RightCurly | '}' at column 24 should be alone on a line. | 159 |
| Warning |
blocks | RightCurly | '}' at column 83 should be alone on a line. | 170 |
| Warning |
blocks | RightCurly | '}' at column 38 should be alone on a line. | 181 |
| Info |
sizes | MethodLength | Method handle length is 329 lines (max allowed is 150). | 193 |
| Warning |
coding | HiddenField | 'animationPanel' hides a field. | 210 |
| Warning |
blocks | LeftCurly | '{' at column 34 should be on a new line. | 214 |
| Warning |
blocks | LeftCurly | '{' at column 30 should be on a new line. | 219 |
| Warning |
blocks | LeftCurly | '{' at column 36 should be on a new line. | 226 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 227 |
| Warning |
blocks | LeftCurly | '{' at column 35 should be on a new line. | 238 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 241 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 243 |
| Warning |
blocks | LeftCurly | '{' at column 34 should be on a new line. | 249 |
| Warning |
blocks | LeftCurly | '{' at column 35 should be on a new line. | 256 |
| Warning |
blocks | LeftCurly | '{' at column 31 should be on a new line. | 263 |
| Warning |
blocks | LeftCurly | '{' at column 33 should be on a new line. | 270 |
| Warning |
blocks | LeftCurly | '{' at column 35 should be on a new line. | 275 |
| Warning |
blocks | LeftCurly | '{' at column 33 should be on a new line. | 280 |
| Warning |
blocks | LeftCurly | '{' at column 35 should be on a new line. | 285 |
| Warning |
blocks | LeftCurly | '{' at column 36 should be on a new line. | 290 |
| Warning |
blocks | LeftCurly | '{' at column 29 should be on a new line. | 295 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 298 |
| Warning |
blocks | LeftCurly | '{' at column 36 should be on a new line. | 313 |
| Warning |
blocks | RightCurly | '}' at column 72 should be alone on a line. | 327 |
| Warning |
blocks | NeedBraces | 'for' construct must use '{}'s. | 339 |
| Warning |
blocks | LeftCurly | '{' at column 32 should be on a new line. | 357 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 358 |
| Warning |
blocks | LeftCurly | '{' at column 33 should be on a new line. | 369 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 370 |
| Warning |
blocks | LeftCurly | '{' at column 33 should be on a new line. | 381 |
| Warning |
blocks | LeftCurly | '{' at column 30 should be on a new line. | 386 |
| Warning |
blocks | LeftCurly | '{' at column 36 should be on a new line. | 391 |
| Warning |
blocks | LeftCurly | '{' at column 33 should be on a new line. | 396 |
| Warning |
blocks | LeftCurly | '{' at column 34 should be on a new line. | 432 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 435 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 437 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 439 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 441 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 443 |
| Warning |
blocks | RightCurly | '}' at column 70 should be alone on a line. | 448 |
| Warning |
blocks | LeftCurly | '{' at column 36 should be on a new line. | 453 |
| Warning |
blocks | LeftCurly | '{' at column 32 should be on a new line. | 459 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 460 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 469 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 471 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 476 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 478 |
| Warning |
blocks | LeftCurly | '{' at column 26 should be on a new line. | 485 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 501 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 503 |
nl/tudelft/simulation/dsol/web/DsolWebServer.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'webServer' must be private and have accessor methods. | 243 |
| Info |
sizes | MethodLength | Method handle length is 357 lines (max allowed is 150). | 260 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 298 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 313 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 315 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 379 |
| Warning |
blocks | NeedBraces | 'for' construct must use '{}'s. | 423 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 443 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 456 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 526 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 528 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 530 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 532 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 534 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 555 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 564 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 566 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 571 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 573 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 597 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 599 |
nl/tudelft/simulation/dsol/web/animation/HtmlGraphics2D.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'background' must be private and have accessor methods. | 52 |
| Warning |
design | VisibilityModifier | Variable 'color' must be private and have accessor methods. | 55 |
| Warning |
design | VisibilityModifier | Variable 'font' must be private and have accessor methods. | 58 |
| Warning |
design | VisibilityModifier | Variable 'canvas' must be private and have accessor methods. | 61 |
| Warning |
design | VisibilityModifier | Variable 'fontMetrics' must be private and have accessor methods. | 64 |
| Warning |
design | VisibilityModifier | Variable 'paint' must be private and have accessor methods. | 67 |
| Warning |
design | VisibilityModifier | Variable 'stroke' must be private and have accessor methods. | 70 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 72 |
| Warning |
design | VisibilityModifier | Variable 'renderingHints' must be private and have accessor methods. | 73 |
| Warning |
design | VisibilityModifier | Variable 'affineTransform' must be private and have accessor methods. | 76 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 78 |
| Warning |
design | VisibilityModifier | Variable 'composite' must be private and have accessor methods. | 79 |
| Warning |
design | VisibilityModifier | Variable 'commands' must be private and have accessor methods. | 82 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 103 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 155 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 163 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 166 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 169 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 171 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 177 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 179 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 181 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 196 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 198 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 218 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 220 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 222 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 224 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 233 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 246 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 279 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 281 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 287 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 289 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 294 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 296 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 353 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 355 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 361 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 363 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 368 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 370 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 444 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 447 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 454 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 457 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 474 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 476 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 482 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 484 |
| Warning |
naming | ParameterName | Name 'Tx' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 677 |
| Warning |
naming | ParameterName | Name 'Tx' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 683 |
| Warning |
coding | HiddenField | 'color' hides a field. | 711 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 748 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 10). | 948 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 11). | 956 |
nl/tudelft/simulation/dsol/web/animation/HtmlGraphicsConfiguration.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'htmlDevice' must be private and have accessor methods. | 26 |
| Warning |
design | VisibilityModifier | Variable 'identityTransform' must be private and have accessor methods. | 29 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 31 |
| Warning |
design | VisibilityModifier | Variable 'bounds' must be private and have accessor methods. | 32 |
| Warning |
coding | HiddenField | 'htmlDevice' hides a field. | 54 |
nl/tudelft/simulation/dsol/web/animation/HtmlGraphicsEnvironment.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'htmlDevice' must be private and have accessor methods. | 26 |
| Warning |
design | VisibilityModifier | Variable 'graphics2D' must be private and have accessor methods. | 29 |
| Warning |
design | VisibilityModifier | Variable 'graphicsConfiguration' must be private and have accessor methods. | 32 |
nl/tudelft/simulation/dsol/web/animation/HtmlToolkit.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'eventQueue' must be private and have accessor methods. | 39 |
nl/tudelft/simulation/dsol/web/animation/TestSwing.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 19 |
| Warning |
misc | FinalParameters | Parameter args should be final. | 38 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 62 |
nl/tudelft/simulation/dsol/web/animation/d2/HtmlAnimationPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 208 |
nl/tudelft/simulation/dsol/web/animation/d2/HtmlGridPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
blocks | RightCurly | '}' at column 29 should be alone on a line. | 183 |
| Warning |
blocks | RightCurly | '}' at column 72 should be alone on a line. | 275 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 338 |
| Warning |
blocks | RightCurly | '}' at column 22 should be alone on a line. | 396 |
| Warning |
blocks | RightCurly | '}' at column 22 should be alone on a line. | 407 |
| Warning |
blocks | RightCurly | '}' at column 22 should be alone on a line. | 418 |
| Warning |
blocks | RightCurly | '}' at column 22 should be alone on a line. | 429 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 629 |
| Warning |
coding | HiddenField | 'extent' hides a field. | 634 |
nl/tudelft/simulation/dsol/web/animation/d2/ToggleButtonInfo.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | FinalParameters | Parameter name should be final. | 25 |
| Warning |
misc | FinalParameters | Parameter visible should be final. | 25 |
| Warning |
misc | FinalParameters | Parameter visible should be final. | 43 |
| Warning |
misc | FinalParameters | Parameter name should be final. | 78 |
| Warning |
misc | FinalParameters | Parameter locatableClass should be final. | 78 |
| Warning |
misc | FinalParameters | Parameter toolTipText should be final. | 78 |
| Warning |
misc | FinalParameters | Parameter visible should be final. | 78 |
| Warning |
misc | FinalParameters | Parameter name should be final. | 116 |
| Warning |
misc | FinalParameters | Parameter visible should be final. | 116 |
| Warning |
misc | FinalParameters | Parameter name should be final. | 144 |
| Warning |
misc | FinalParameters | Parameter layerName should be final. | 144 |
| Warning |
misc | FinalParameters | Parameter toolTipText should be final. | 144 |
| Warning |
misc | FinalParameters | Parameter visible should be final. | 144 |